Add update support for machine type, min cpu platform, and service accounts #1005
Conversation
|
Do we want to add an additional protection like I suggested in the issue? The main problem I see is that we don't have a way to notify our users at plan time that this update will stop their instance (effectively dropping traffic). The behavior before was ForceNew. If people used a create_before_destroy, the new instances would be up first and could start serving traffic without downtime. |
|
Done. |
…counts (hashicorp#1005) * Add update support for compute instance fields that require the machine to be stopped * add warnings in docs about stopping the instance before updating * add allow_stopping_for_update field
Signed-off-by: Modular Magician <[email protected]>
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
All three of these require the machine to be stopped before updating. I also added a warning in the docs for each of these fields.
Following the example of hashicorp/terraform#11998 of just going ahead and doing the stopping.
Fixes #728.